Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate timeout_commit and timeout_propose config #1551

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Dec 9, 2024

Closes #1550

Testing

In celestia-app I replaced celestia-core with this repo. Then created a new config file and observed:

# How long we wait for a proposal block before prevoting nil
# Deprecated: timeout_commit is overridden by the state machine in app version >= 3.
# Therefore, the value set in this config will be ignored.
timeout_propose = "3.5s"

# How long we wait after committing a block, before starting on the new
# height (this gives us a chance to receive some more precommits, even
# though we already have +2/3).
# Deprecated: timeout_commit is overridden by the state machine in app version >= 3.
# Therefore, the value set in this config will be ignored.
timeout_commit = "4.2s"

@rootulp rootulp self-assigned this Dec 9, 2024
@rootulp rootulp requested a review from a team as a code owner December 9, 2024 19:13
@rootulp rootulp requested review from cmwaters, evan-forbes, rach-id and ninabarbakadze and removed request for a team December 9, 2024 19:13
rach-id
rach-id previously approved these changes Dec 9, 2024
config/toml.go Outdated Show resolved Hide resolved
config/toml.go Outdated Show resolved Hide resolved
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
@rootulp rootulp requested a review from rach-id December 9, 2024 21:16
@rootulp rootulp merged commit 890a59b into celestiaorg:v0.34.x-celestia Dec 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate config for timeout_commit and timeout_propose
3 participants