Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate time to consensus for really large block sizes #438

Closed
3 tasks
Tracked by #514
evan-forbes opened this issue Jun 25, 2021 · 2 comments
Closed
3 tasks
Tracked by #514

Investigate time to consensus for really large block sizes #438

evan-forbes opened this issue Jun 25, 2021 · 2 comments
Labels
T:investigate Further investigation needed

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Jun 25, 2021

Summary

As touched on in the experimental section of #381, we should further explore the consequences of creating large blocks during consensus.

Details

With our recent switch to propagating blocks using the standard tendermint block gossiping mechanism #423, we should perform some experiments to give us a better idea of the limitations of increasing the amount of block data included in each block proposed during consensus.

Action Items

  • create experiment to spin up a devnet using the dummyapp
  • observe the affect of increasing the amount of block data on time to consensus
  • (bonus) observe the affect of altering the size of the messages gossiped using the PartSetHeader

References

tracking issue #384
more discussion on potentially different mechanisms of block propagation during consensus #434 #423
introduction of the dummyapp #384

blocked by #436

@liamsi
Copy link
Member

liamsi commented Apr 15, 2022

Osmosis blocks are often about 2mb and with 7sec block time. During Game of Stake we experimented with larger blocks as well (according to Zaki up 20 mb with no issues). IMO, we should still test this but 4mb blocks (meaning 4mb ODS) are really sufficient. Particularly the interplay with celestia-node and sampling should be tested.

@evan-forbes
Copy link
Member Author

During the onsite, we ran tests using our testground setup. We had trouble reaching consensus using 8MB blocks with 40 validators unless we allowed for 1GB/s connections for each validator. If we increased the proposal timeout for each node, we were able to reach consensus using 320MB/s connection per each node.

This appears to be caused by some inefficiencies in tendermint p2p stack, but we will be adding more introspection to the testground tests soon. We will continuously run various tests after the introspection is added, so I think its safe to close this issue.

Repository owner moved this from TODO to Done in Celestia Node Nov 8, 2022
evan-forbes pushed a commit that referenced this issue Jun 9, 2023
* Update go-built-in.md (#438)

(cherry picked from commit 06eeaaa)

# Conflicts:
#	docs/tutorials/go-built-in.md

* Revert "Update go-built-in.md (#438)"

This reverts commit b197c0883dad94b03d80aba709798e6a80ba103f.

* Update go-built-in.md (#438)

---------

Co-authored-by: Aliasgar Merchant <[email protected]>
Co-authored-by: Sergio Mena <[email protected]>
Co-authored-by: Adi Seredinschi <[email protected]>
Co-authored-by: lasarojc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:investigate Further investigation needed
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants