Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy share merging #636

Closed
evan-forbes opened this issue Feb 24, 2022 · 0 comments · Fixed by #637
Closed

Add lazy share merging #636

evan-forbes opened this issue Feb 24, 2022 · 0 comments · Fixed by #637

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Feb 24, 2022

We want to solve issues such as #455, #454, and #77. This will require mechanisms to either estimate or accurately count the number of shares that a given set of transactions will actually take up. While we could create such mechanisms, they would be mirroring the share merging logic that we already have. It would likely be better if we could instead lazily add shares to a square. That way, instead of creating a new mechanism to count or estimate shares, we simply generate the shares as we go.

As a bonus, this will also set us up to solve #626, as we will already be generating the square during the PrepareProposal step, which will make generating the DataAvailabilityHeader and DataRoot trivial.

@liamsi liamsi moved this to TODO in Celestia Node Apr 15, 2022
Repository owner moved this from TODO to Done in Celestia Node Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant