feat: Lazy share writers #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
liamsi,
Wondertan,
adlerjohn and
rach-id
and removed request for
tac0turtle
evan-forbes
commented
Feb 24, 2022
|
blocked by #631, so converting to a draft |
adlerjohn
approved these changes
Apr 13, 2022
liamsi
reviewed
Apr 14, 2022
liamsi
reviewed
Apr 14, 2022
liamsi
reviewed
Apr 14, 2022
liamsi
reviewed
Apr 14, 2022
liamsi
reviewed
Apr 20, 2022
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors share merging to be lazy. This is needed to efficiently fill the data square.
Closes: #636
Github shows previous commits as part of this PR even though they do not contribute to the changes of this PR.
The changes introduced in this PR: https://github.com/celestiaorg/celestia-core/pull/637/files/68e4e18c3d6abde34dc160fef08124b4f6afcdca..4aa56e021309e70f7267e258eecab11d2bf30cf3