chore: backport #1084, #1089 and #1088 #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR records that we have sent the peer the transaction to avoid doing it a second time
TTLs are currently only checked on `Update` which is only when a block is committed. In the rare event that a block takes several rounds to commit (because of a faulty transaction that is halting the chain), a transaction can outlast the TTLDuration that was set by the node operator. This PR initiates a separate go routine for both the `v1` and `cat` mempools that will routinely check for expired transactions and remove them regardless of when `Update` is called
evan-forbes
approved these changes
Sep 25, 2023
staheri14
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports three commits from main
#1084, #1089 and #1088
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments