-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix typos #1149
chore: fix typos #1149
Conversation
Which linter or CI check do you propose adding? This repo already enabled Line 18 in 4b6c2dd
|
Got it. I'll update to pass the check and also close the CI PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some of these typos may exist in upstream https://github.com/cometbft/cometbft if you'd like to make a similar PR there
Thanks for your contribution!
Co-authored-by: Rootul P <[email protected]>
IMO we should ignore the failing govulncheck on this PR and instead tackle separately in #1151 |
`=== Informational === Found 2 vulnerabilities in packages that you import, but there are no call Vulnerability #1: GO-2023-2186 Vulnerability #2: GO-2023-2102 Your code is affected by 2 vulnerabilities from the Go standard library.` |
The failing check could be from json or toml. Please let's me check. |
@rootulp Can you rerun the e2e test sir, I don't think I touch any config files |
Thanks for the ping! Sorry the CI on this repo is flakey. Re-running. |
Description
This PR will fix every typos exist on current repo. After this we can add another CI to check for typo per PR submit.
PR checklist
.changelog
(we useunclog to manage our changelog)
docs/
orspec/
) and code comments