Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: MConnection benchmark #1176

Merged
merged 23 commits into from
Jan 19, 2024
Merged

test: MConnection benchmark #1176

merged 23 commits into from
Jan 19, 2024

Conversation

staheri14
Copy link
Collaborator

@staheri14 staheri14 commented Jan 17, 2024

A PR towards #1162

This PR introduces a comprehensive benchmark suite for MConnection, aimed at pinpointing performance bottlenecks. The tests evaluate the following aspects:

  • Evaluating send queue capacity impact on the message transmission delay
  • Assessing whether MConnection can fully utilize its maximum bandwidth
  • Testing performance beyond available bandwidth i.e., send and receive rates. This is to determine how the system behaves when message rates surpass the available bandwidth.

So far, no significant bottlenecks have been identified. In a follow-up PR, I plan to adjust additional parameters and will share the results and insights gained from these tests.

@staheri14 staheri14 self-assigned this Jan 17, 2024
@staheri14 staheri14 added the WS: Big Blonks 🔭 Improving consensus critical gossiping protocols label Jan 17, 2024
@staheri14 staheri14 changed the title WIP: MConnection benchmark test: MConnection benchmark Jan 18, 2024
@staheri14 staheri14 marked this pull request as ready for review January 18, 2024 02:37
@staheri14 staheri14 requested a review from rootulp January 18, 2024 02:46
rootulp
rootulp previously approved these changes Jan 18, 2024
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. The test is really clearly written, thanks!

@staheri14 staheri14 requested a review from rootulp January 18, 2024 20:27
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope

@staheri14 staheri14 merged commit 07c167e into main Jan 19, 2024
18 checks passed
@staheri14 staheri14 deleted the sanaz/mconnection-tests branch January 19, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block prop testing WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants