Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TxStatus rpc endpoint #1178

Merged
merged 21 commits into from
Mar 29, 2024
Merged

feat: add TxStatus rpc endpoint #1178

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b430b1d
feat: add TxStatus rpc endpoint
ninabarbakadze Jan 19, 2024
3a9fbd3
wip
ninabarbakadze Jan 25, 2024
5098273
feat: add pruning logic to txs as well
ninabarbakadze Jan 26, 2024
8b75c63
Merge branch 'main' into nina/tx-status-rpc-endpoint
ninabarbakadze Jan 29, 2024
a5a7652
chore: comment out unimplemented fucntion for now
ninabarbakadze Jan 29, 2024
d6b5bd4
refacotor: save txs in a batch, pruning not fully functioning
ninabarbakadze Mar 20, 2024
2483567
refactor: use tx index from cmtstore
ninabarbakadze Mar 21, 2024
b9b4737
refactor: remove commit from struct
ninabarbakadze Mar 21, 2024
9c9ece4
test: block test working
ninabarbakadze Mar 22, 2024
bcd56c2
chore: cleanup
ninabarbakadze Mar 25, 2024
74abc3b
refactor: minor changes
ninabarbakadze Mar 25, 2024
c085e04
chore: merge
ninabarbakadze Mar 25, 2024
f32bc93
style: remove whitespace
ninabarbakadze Mar 25, 2024
dc88650
Update store/store.go
ninabarbakadze Mar 26, 2024
63211df
refactor: rename txstatus to txinfo and add rpc endpoint to light nodes
ninabarbakadze Mar 27, 2024
21de961
Merge branch 'main' into nina/tx-status-rpc-endpoint
ninabarbakadze Mar 27, 2024
de0011b
test: change the height assertion
ninabarbakadze Mar 27, 2024
7658b7c
chore: nits
ninabarbakadze Mar 27, 2024
597c778
Update rpc/core/types/responses.go
ninabarbakadze Mar 28, 2024
9da6cba
Update rpc/core/mempool.go
ninabarbakadze Mar 28, 2024
7f85470
Update proto/tendermint/store/types.proto
ninabarbakadze Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ require (
github.com/go-git/go-git/v5 v5.11.0
github.com/vektra/mockery/v2 v2.14.0
gonum.org/v1/gonum v0.8.2
google.golang.org/protobuf v1.31.0
google.golang.org/protobuf v1.32.0
)

require (
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,6 +1454,8 @@ google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQ
google.golang.org/protobuf v1.27.1/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc=
google.golang.org/protobuf v1.31.0 h1:g0LDEJHgrBl9N9r17Ru3sqWhkIx2NB67okBHPwC7hs8=
google.golang.org/protobuf v1.31.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
google.golang.org/protobuf v1.32.0 h1:pPC6BG5ex8PDFnkbrGU3EixyhKcQ2aDuBS36lqK/C7I=
google.golang.org/protobuf v1.32.0/go.mod h1:c6P6GXX6sHbq/GpV6MGZEdwhWPcYBgnhAHhKbcUYpos=
gopkg.in/alecthomas/kingpin.v2 v2.2.6/go.mod h1:FMv+mEhP44yOT+4EoQTLFTRgOQ1FBLkstjWtayDeSgw=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
Expand Down
245 changes: 239 additions & 6 deletions proto/tendermint/store/types.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions proto/tendermint/store/types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@ message BlockStoreState {
int64 base = 1;
int64 height = 2;
}

message TxIndex {
int64 height = 1;
int64 index = 2;
bool committed = 3;
ninabarbakadze marked this conversation as resolved.
Show resolved Hide resolved
}
1 change: 1 addition & 0 deletions rpc/core/mempool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ func BroadcastTxSync(ctx *rpctypes.Context, tx types.Tx) (*ctypes.ResultBroadcas
}
}

// DEPRECATED: Use other broadcast methods instead.
ninabarbakadze marked this conversation as resolved.
Show resolved Hide resolved
// BroadcastTxCommit returns with the responses from CheckTx and DeliverTx.
// More: https://docs.cometbft.com/v0.34/rpc/#/Tx/broadcast_tx_commit
func BroadcastTxCommit(ctx *rpctypes.Context, tx types.Tx) (*ctypes.ResultBroadcastTxCommit, error) {
Expand Down
1 change: 1 addition & 0 deletions rpc/core/routes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ var Routes = map[string]*rpc.RPCFunc{
"consensus_params": rpc.NewRPCFunc(ConsensusParams, "height", rpc.Cacheable("height")),
"unconfirmed_txs": rpc.NewRPCFunc(UnconfirmedTxs, "limit"),
"num_unconfirmed_txs": rpc.NewRPCFunc(NumUnconfirmedTxs, ""),
// "tx_status": rpc.NewRPCFunc(TxStatus, "hash"),

// tx broadcast API
"broadcast_tx_commit": rpc.NewRPCFunc(BroadcastTxCommit, "tx"),
Expand Down
Loading
Loading