feat: add more consensus metrics on rejected proposals #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
requested review from
evan-forbes,
staheri14,
rach-id,
ninabarbakadze and
rootulp
as code owners
rootulp
approved these changes
Feb 6, 2024
Yup |
staheri14
approved these changes
Feb 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
This adds two counters to the consensus metrics: - ApplicationRejectedProposals - TimedOutProposals It also adds a third `StartHeight` which is set once upon start so we know how many heights the metrics have been running for (cherry picked from commit 938fb01)
cmwaters
pushed a commit
that referenced
this pull request
Feb 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds two counters to the consensus metrics:
It also adds a third
StartHeightwhich is set once upon start so we know how many heights the metrics have been running forPR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments