fix: fixes round state traced data to mirror the new state #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staheri14
changed the title
staheri14
added
fix
WS: Big Blonks 🔭
|
|
staheri14
requested review from
evan-forbes,
cmwaters,
rach-id,
ninabarbakadze and
rootulp
as code owners
evan-forbes
approved these changes
Mar 14, 2024
Comment on lines
-709
to
+711
| schema.WriteRoundState(cs.traceClient, cs.Height, cs.Round, cs.Step) | ||
| schema.WriteRoundState(cs.traceClient, cs.RoundState.Height, | ||
| cs.RoundState.Round, | ||
| cs.RoundState.Step) |
There was a problem hiding this comment.
is this just being more explicit to where the height and round are coming from?
There was a problem hiding this comment.
totally fine to change, but not yet sure if I would classify this as a fix as I currently understand this
|
Closing this as the issue was already resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1258