-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use a separate lookup map for reserving txs #1272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
previously approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
evan-forbes
previously approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps a bit excessive, but we could also add an explicit test against reading
func TestReadReserved(t *testing.T) {
store := newStore()
tx := types.Tx("tx1")
store.reserve(tx.Key())
assert.Nil(t, store.get(tx.Key()))
assert.False(t, store.has(tx.Key()))
assert.Len(t, store.getAllKeys(), 0)
assert.Len(t, store.getAllTxs(), 0)
}
rootulp
approved these changes
Mar 21, 2024
evan-forbes
approved these changes
Mar 21, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
(cherry picked from commit 23604b6)
cmwaters
added a commit
that referenced
this pull request
Mar 25, 2024
) This is an alternative to #1267 that solves the current problem with reserving transactions by using a separate lookup map as suggested by @rootulp.<hr>This is an automatic backport of pull request #1272 done by [Mergify](https://mergify.com). Co-authored-by: Callum Waters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1267 that solves the current problem with reserving transactions by using a separate lookup map as suggested by @rootulp.