-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: flush the local tracer every 30s #1541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golangci-lint is complaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this PR modifies the function signature of some exported functions in the pkg/trace package so it may technically be considered breaking. NBD if we don't add !
to the PR title though b/c I assume you'll bump to this change in celestia-app and handle the function signature change
I didn't know it was used in app. Where is it please? @rootulp |
Oops nvm it isn't used in app. Disregard |
Closing this as I think it's unnecessary. The issue was happening because I was running a small network, only running 2 reactors, and the buffer doesn't receive enough data to write it. However, in a realistic network, running all reactors, this shouldn't happen. |
This changes help to flush the buffered writer in the file every 30s if not enough updates are happening.
This solves the issue of not seeing any traces when running a stable network