Move consts, ipfs, and ipld to pkg #508
Conversation
There was a problem hiding this comment.
I think it's OK to hold off moving these into a separate repo until we actually run into the problem of circular dependencies. The pkg dir always stirred some controversy around go devs (e.g. see: golang-standards/project-layout#10). I do think it's useful to signal: "hey these modules are specifically meant to be used as a library".
What is the next step with this? My understanding is that a lot of the code that currently uses this will actually be not using it anymore; is that right?
Would also like to hear @Wondertan's opinion on this.
yeah, we'd definitely remove and refactor some code, this is only an intermediate step that will hopefully make the review process for the next steps easier. Those next steps would be to complete #506 and #505. Eventually, I think we'd move things into their own package as discussed in #296 |
There was a problem hiding this comment.
This looks good to me but I want @Wondertan to review it before merging as it might collide with some of his plans in celestiaorg/celestia-node#21 ?
* move ipfs and ipld packages to new pkg/da/ * moved consts to pkg * clean up
* Move consts, ipfs, and ipld to pkg (#508) * move ipfs and ipld packages to new pkg/da/ * moved consts to pkg * clean up * go mod tidy
* Move consts, ipfs, and ipld to pkg (#508) * move ipfs and ipld packages to new pkg/da/ * moved consts to pkg * clean up * go mod tidy
* Move consts, ipfs, and ipld to pkg (#508) * move ipfs and ipld packages to new pkg/da/ * moved consts to pkg * clean up * go mod tidy
* Move consts, ipfs, and ipld to pkg (#508) * move ipfs and ipld packages to new pkg/da/ * moved consts to pkg * clean up * go mod tidy
Description
This super simple PR moves the consts, ipld, and ipfs packages to pkg and that's it. I was strict in limiting changes of this PR in hopes of making the review process for this and future PRs simpler.
Part of #506