Remove IPFS code #523
Merged
Remove IPFS code #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
reviewed
Aug 30, 2021
There was a problem hiding this comment.
Looks good to me!
Also, I think we can go even further and remove mentions of IPLD/IPFS entirely from this repo. The only DA thing required in Core is an ability to verify erasure coding during consensus and for this, we can omit IPLD usage, specifically, NMTNodeAdder, as it's needed only to store, provide, and serve shares. Luckily, we don't need those functions in Core and only calculations. So the end EDS calculation could look like this(but without adder).
Wondertan
approved these changes
Aug 30, 2021
| @@ -16,50 +16,24 @@ require ( | |||
| github.com/gogo/protobuf v1.3.2 | |||
| github.com/golang/protobuf v1.5.2 | |||
| github.com/google/btree v1.0.0 | |||
| github.com/gopherjs/gopherjs v0.0.0-20190812055157-5d271430af9f // indirect | |||
There was a problem hiding this comment.
This module is necessary because github.com/gopherjs/gopherjs/js is imported in:
- github.com/celestiaorg/celestia-core/cmd/tendermint/commands
-- github.com/spf13/viper
--- gopkg.in/ini.v1
---- gopkg.in/ini.v1.test
----- github.com/smartystreets/goconvey/convey
------ github.com/jtolds/gls
| github.com/petermattis/goid v0.0.0-20180202154549-b0b1615b78e5 // indirect | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/prometheus/client_golang v1.11.0 | ||
| github.com/rcrowley/go-metrics v0.0.0-20200313005456-10cdbea86bc0 | ||
| github.com/rs/cors v1.8.0 | ||
| github.com/sasha-s/go-deadlock v0.2.0 | ||
| github.com/smartystreets/assertions v1.0.1 // indirect |
There was a problem hiding this comment.
This module is necessary because github.com/smartystreets/assertions is imported in:
- github.com/celestiaorg/celestia-core/cmd/tendermint/commands
-- github.com/spf13/viper
--- gopkg.in/ini.v1
---- gopkg.in/ini.v1.test
----- github.com/smartystreets/goconvey/convey
perhaps a different version of viper doesn't have these
4 tasks
|
just saw this went through, will complete teh update to tm 0.35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removes the IPFS and IPLD packages completely to avoid importing our fork of IPFS. Notably keeps the nmt plugin.
part of #506