Refactor how to create DataAvailabilityHeaders (#524) #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use [][]byte instead of interval digests * add extra DAH methods * move the dataavailabilityheader from types to da * refactor creating DAHs * finish refactor and clean up * add tests * linter * typos causing tests to fail * fix docs * remove test used while debugging * add docs to indicate that computing the shares also padds them * update to the latest version of nmt * change version of checkout to hopefully fix the proto lint ci test * update hashes to account for new verison of nmt add refactored DAH and nmt wrapper
|
the proto linter is broken on the CI because it complains about some versioning issues that should be addressed upstream, but works fine locally |
liamsi
approved these changes
Sep 20, 2021
|
Approved as this is the same as already reviewed #524. I'd recommend creating a merge commit instead of squashing this maybe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
simple PR that cherry picks the recent DataAvailabiltyHeader refactor along with including the nmt wrapper
part of #528