Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pull changes from upstream 0.34.x release #562

Merged
merged 19 commits into from
Oct 18, 2021

Conversation

evan-forbes
Copy link
Member

Description

didn't want to get too far behind upstream, so pulling in changes while we decide on what to do with the bot #558

williambanfield and others added 19 commits August 17, 2021 11:46
(cherry picked from commit a4cc831)

Co-authored-by: Sam Kleinman <[email protected]>
I realized after my last commit that my change made a following line of code a bit redundant.

(alternatively my last change was redunadnt to the existing code.)

I took this oppertunity to make some minor cleanups and logging changes to the node changes which I hope will make tests a bit more clear.

(cherry picked from commit a374f74)

Co-authored-by: Sam Kleinman <[email protected]>
Issues reported in Osmosis, where the message is extremely long. Also, there is absolutely no reason to log the message IMO. If we must, we can make the message log DEBUG.

(cherry picked from commit 58a6cff)

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
This change backports the PostgreSQL indexing sink, addressing part of #6828.

Development on the main branch has diverged substantially since the v0.34.x
release. It includes package moves, breaking API and protobuf schema changes,
and new APIs, all of which together have a large footprint on the mapping
between the implementation at tip and the v0.34 release branch.

To avoid the need to retrofit all of those improvements, this change works by
injecting the new indexing sink into the existing (v0.34) indexing interfaces
by delegation. This means the backport does _not_ pull in all the newer APIs
for event handling, and thus has minimal impact on existing code written
against the v0.34 package structure.

This change includes the test for the `psql` implementation, and thus updates
some Go module dependencies. Because it does not interact with any other types,
however, I did not add any unit tests to other packages in this change.

Related changes:
 * Update module dependencies for psql backport.
 * Update test data to be type-compatible with the old protobuf types.
 * Add config settings for the PostgreSQL indexer.
 * Clean up some linter settings.
 * Hook up the psql indexer in the node main.
I accidentally omitted this from the backport in #6906.
Fixes #7043.
…78) (#7085)

* e2e: abci protocol should be consistent across networks (#7078)

It seems weird in retrospect that we allow networks to contain
applications that use different ABCI protocols.

(cherry picked from commit f2a8f5e)
(cherry picked from commit befd669)

Co-authored-by: Sam Kleinman <[email protected]>
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but in the future (or maybe now) is there a way to put in the PR description some link or something to show that these commits all come from upstream, and are the diff between our version and whatever version you're pulling from?

@evan-forbes
Copy link
Member Author

evan-forbes commented Oct 16, 2021

Looks fine to me, but in the future (or maybe now) is there a way to put in the PR description some link or something to show that these commits all come from upstream, and are the diff between our version and whatever version you're pulling from?

was thinking about this earlier, and the best way to do this might be to hard reset merge all upstream commits, then add an additional commit that merges origin master and shows all the conflicts. will try this fix this tmrw and see how much extra work it is.

@evan-forbes
Copy link
Member Author

will try the new approach that will hopefully make it easier to review this friday when we pull the changes again

@evan-forbes evan-forbes merged commit fbfa8ce into v0.34.x-celestia Oct 18, 2021
@evan-forbes evan-forbes deleted the evan/pull-0.34.x-release-changes branch October 18, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants