fix(nodebuilder/header): header metrics initialisation now moved to s…

…tore construction due to dep bump
celestiaorg · Dec 23, 2023 · 78b8557 · 78b8557
1 parent da07fd3
commit 78b8557
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/nodebuilder/header/constructors.go b/nodebuilder/header/constructors.go
@@ -99,16 +99,14 @@ func newInitStore[H libhead.Header[H]](
 	ds datastore.Batching,
 	ex libhead.Exchange[H],
 ) (libhead.Store[H], error) {
-	s, err := store.NewStore[H](ds, store.WithParams(cfg.Store))
-	if err != nil {
-		return nil, err
+	opts := []store.Option{store.WithParams(cfg.Store)}
+	if MetricsEnabled {
+		opts = append(opts, store.WithMetrics())
 	}
 
-	if MetricsEnabled {
-		err = libhead.WithMetrics[H](s)
-		if err != nil {
-			return nil, err
-		}
+	s, err := store.NewStore[H](ds, opts...)
+	if err != nil {
+		return nil, err
 	}
 
 	trustedHash, err := cfg.trustedHash(net)

diff --git a/share/eds/byzantine/byzantine.go b/share/eds/byzantine/byzantine.go
@@ -4,9 +4,10 @@ import (
 	"context"
 	"fmt"
 
+	"github.com/ipfs/boxo/blockservice"
+
 	"github.com/celestiaorg/celestia-app/pkg/da"
 	"github.com/celestiaorg/rsmt2d"
-	"github.com/ipfs/boxo/blockservice"
 
 	"github.com/celestiaorg/celestia-node/share/ipld"
 )