ipld: adding IPLD package to provide helpers for dealing with IPLD-based data storage #110
Conversation
renaynay
force-pushed
the
ipld-plugin
branch
2 times, most recently
from
3e352ed to
fc5d319
Compare
|
should we be including the test file for the plugin? https://github.com/celestiaorg/celestia-core/blob/c4f2a98f4928d3b04517621c5792744c106ba306/pkg/da/ipfs/plugin/nmt_test.go I managed to get the above tests to work by switching to an older version of go (1.15.6), as quic-go has a dependecy that is archived and won't work with any version greater than that. https://github.com/marten-seemann/qtls |
At least this test uses the ipfs API which I don't think is the plan here. The other tests make sense. Surprised that quic would be a dependency then though 🤔 |
| @@ -2,19 +2,27 @@ module github.com/celestiaorg/celestia-node | |||
|
|
|||
| go 1.16 | |||
|
|
|||
| replace github.com/ipfs/go-verifcid => github.com/celestiaorg/go-verifcid v0.0.1-lazypatch | |||
There was a problem hiding this comment.
Unfortunately, this is still required as we rely on Blockservice which relies on this check. We can remove this once we migrate to newer IPLD stack.
| github.com/celestiaorg/rsmt2d v0.3.0 | ||
| github.com/ipfs/go-bitswap v0.4.0 | ||
| github.com/ipfs/go-bitswap v0.3.4 |
There was a problem hiding this comment.
Well, this downgrade was not supposed to happen 🤔
There was a problem hiding this comment.
That's my bad. Rene updated to the latest versions of ipld etc and I told her to use the same versions of that stack that worked in core (and bitswap v0.3.4 was used there IIRC). Thanks for opening #137.
There was a problem hiding this comment.
@renaynay, it would be cool if you did here the same mistake as in #97 and co-authored all commits here with me and @evan-forbes, as you did for yourself 😉
| github.com/ipfs/go-merkledag v0.4.0 | ||
| github.com/ipfs/go-merkledag v0.3.2 | ||
| github.com/ipfs/go-peertaskqueue v0.4.0 // indirect | ||
| github.com/ipld/go-ipld-prime v0.11.0 // indirect |
There was a problem hiding this comment.
Well, we should double-check why this dependency is here. That's basically an import of the newer IPLD stack that we are not using.
@adlerjohn, It should be optimized once we have celestiaorg/rsmt2d#60 |
This PR adds in the IPLD plugin that was previously in core (ref). This plugin is necessary for
BlockStoreas we are using Bitswap to exchange block data.Eventually this plugin should be removed from this repository (as per #111).