chore!: upgrade to celestia-app v0.7.0 #1147

rootulp · 2022-09-21T21:22:15Z

header/pb/extended_header.proto

header/store/heightsub.go

ipld/plugin/nmt.go

codecov-commenter · 2022-09-22T01:34:06Z

Codecov Report

Merging #1147 (44c8d92) into main (793e2b0) will increase coverage by 0.26%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   55.55%   55.82%   +0.26%     
==========================================
  Files         160      160              
  Lines        9853     9862       +9     
==========================================
+ Hits         5474     5505      +31     
+ Misses       3841     3825      -16     
+ Partials      538      532       -6

Impacted Files	Coverage Δ
header/header.go	`50.00% <0.00%> (ø)`
header/pb/extended_header.pb.go	`36.50% <ø> (ø)`
header/serde.go	`27.27% <ø> (ø)`
header/testing.go	`89.56% <ø> (ø)`
service/rpc/share.go	`0.00% <0.00%> (ø)`
share/add.go	`77.35% <ø> (ø)`
share/availability/cache/availability.go	`87.50% <ø> (ø)`
share/availability/test/testing.go	`67.39% <ø> (ø)`
share/byzantine.go	`69.23% <ø> (ø)`
share/eds/retriever.go	`91.97% <ø> (ø)`
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rootulp · 2022-09-22T01:51:19Z

Integ test failed CI. Will debug tomorrow

Wondertan · 2022-09-22T15:21:42Z

@rootulp, is it ready for review?

rootulp · 2022-09-22T15:22:29Z

@Wondertan nope, sorry I haven't investigated why integ test is failing yet.

Wondertan · 2022-09-22T15:22:30Z

Note that we have one flakey integration test that may be annoying for you to debug

rootulp · 2022-09-22T15:23:03Z

Noted. I just started a third retry

rootulp · 2022-09-22T17:41:40Z

Notes from investigation:

This log is suspect: starting Bridge Node: square size is not a power of two: 0 (link). The error appears to originate from celestia-app shares.Split even though the block size in this test is 16 per this line.
It seems plausible that the block data used in this test (link) isn't splittable by celestia-app
I verified that squareSize is indeed the issue at least for the TestFullReconstructFromBridge integ test. Hacky workaround was to add b.Data.OriginalSquareSize = 16 immediately before this line which makes the test pass.

Synchronous debugging with @evan-forbes

The current swamp tests use a kvstore application. We want to replace the kvstore application with celestia-app in order for celestia-app to properly set the square size. We're tackling this by exporting a public function from celestia-app: Export a public testutil function for use in celestia-node swamp tests celestia-app#770

Wondertan · 2022-09-23T09:18:40Z

Thanks, @rootulp. Mockable App is something we have wanted for a while already, and it just has never been a priority. From your message, it seems like it is blocking the update now, right?

rootulp · 2022-09-23T13:46:45Z

Yep blocking. @evan-forbes is working on a slightly different approach to unblock this PR.

header/store/heightsub.go

service/rpc/share.go

rootulp · 2022-09-29T13:55:25Z

Blocked on celestiaorg/celestia-app#770

rootulp · 2022-10-07T18:44:51Z

Update: blocked on #628 and #1160

Wondertan · 2022-10-11T16:35:12Z

@rootulp, the #1160 is now merged, so you freely continue here.

Ping if anything is needed from our side

go.mod

nodebuilder/tests/swamp/swamp.go

header/store/heightsub.go

nodebuilder/tests/swamp/swamp.go

nodebuilder/tests/swamp/swamp_tx.go

share/availability/light/availability_test.go

share/availability/test/testing.go

share/availability/light/availability_test.go

header/header.go

rootulp · 2022-10-13T16:14:02Z

Another instance of #1090 encountered here

Co-authored-by: rene <[email protected]>

This reverts commit 44c8d92.

Wondertan

LGTM. Thank you for the help ❤️

Left two non-blocking optional nits

nodebuilder/tests/swamp/config.go

nodebuilder/tests/swamp/swamp.go

share/availability/light/availability_test.go

chore: upgrade to celestia-app v0.7.0-rc3

d649645

rootulp added area:core_and_app Relationship with Core node and Celestia-App kind:deps Pull requests that update a dependency file T:dependencies labels Sep 21, 2022

rootulp self-assigned this Sep 21, 2022

evan-forbes mentioned this pull request Sep 21, 2022

Merge QGB feature branch into main celestiaorg/celestia-app#742

Merged

rootulp added 3 commits September 21, 2022 20:53

make fmt

f969f4e

make lint && make fmt

697289a

fix: TestSharesRoundTrip

100bfe3

rootulp commented Sep 22, 2022

View reviewed changes

header/pb/extended_header.proto Show resolved Hide resolved

header/store/heightsub.go Outdated Show resolved Hide resolved

ipld/plugin/nmt.go Outdated Show resolved Hide resolved

rach-id reviewed Sep 24, 2022

View reviewed changes

header/store/heightsub.go Outdated Show resolved Hide resolved

service/rpc/share.go Outdated Show resolved Hide resolved

chore: address @sweexordious feedback

90c9d2f

Bidon15 mentioned this pull request Oct 11, 2022

refactor(swamp): use celestia-app instead of the kvstore #1160

Merged

rootulp commented Oct 11, 2022

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Merge branch 'main' into rp/upgrade-celestia-app

49ebcc4

rootulp changed the title ~~chore: upgrade to celestia-app v0.7.0-rc3~~ chore: upgrade to celestia-app v0.7.0-rc5 Oct 11, 2022

chore: prefer import alias appshares

e2b3051

rootulp mentioned this pull request Oct 11, 2022

Cherry-pick testnode changes to main celestiaorg/celestia-app#860

Closed

rootulp marked this pull request as ready for review October 13, 2022 04:41

rootulp requested review from renaynay, Wondertan, vgonkivs and distractedm1nd as code owners October 13, 2022 04:41

rootulp commented Oct 13, 2022

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Wondertan reviewed Oct 13, 2022

View reviewed changes

nodebuilder/tests/swamp/swamp.go Outdated Show resolved Hide resolved

header/store/heightsub.go Outdated Show resolved Hide resolved

renaynay reviewed Oct 13, 2022

View reviewed changes

evan-forbes added 6 commits October 13, 2022 08:23

chore: use configs and params in components

4f789c8

chore: use supress logs from components

41cb3f9

fix: account generation

f8b4ac4

fix: fill multiple blocks instead of only one

ce0f834

fix: linter

a94bd15

chore: use official version of the app

f4cb3ee

Bidon15 mentioned this pull request Oct 13, 2022

chore: upgrade test-infra to latest releases from node + app celestiaorg/test-infra#90

Merged

fix: remove log import

e321b85

rootulp and others added 3 commits October 13, 2022 12:14

Update share/availability/light/availability_test.go

c8b5b26

Co-authored-by: rene <[email protected]>

Update share/availability/test/testing.go

44c8d92

Co-authored-by: rene <[email protected]>

Revert "Update share/availability/test/testing.go"

0949ab2

This reverts commit 44c8d92.

rootulp changed the title ~~chore: upgrade to celestia-app v0.7.0-rc5~~ chore: upgrade to celestia-app v0.7.0 Oct 13, 2022

rootulp mentioned this pull request Oct 13, 2022

Set useShareIndexes=true in availability_test.go #1231

Open

rootulp requested review from evan-forbes, renaynay and Wondertan October 13, 2022 16:53

Wondertan approved these changes Oct 14, 2022

View reviewed changes

nodebuilder/tests/swamp/config.go Show resolved Hide resolved

nodebuilder/tests/swamp/swamp.go Show resolved Hide resolved

renaynay approved these changes Oct 14, 2022

View reviewed changes

share/availability/light/availability_test.go Show resolved Hide resolved

evan-forbes merged commit 738b69f into celestiaorg:main Oct 14, 2022

rootulp deleted the rp/upgrade-celestia-app branch October 14, 2022 11:26

rootulp changed the title ~~chore: upgrade to celestia-app v0.7.0~~ chore!: upgrade to celestia-app v0.7.0 Oct 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore!: upgrade to celestia-app v0.7.0 #1147

chore!: upgrade to celestia-app v0.7.0 #1147

rootulp commented Sep 21, 2022 •

edited

Loading

codecov-commenter commented Sep 22, 2022 •

edited

Loading

rootulp commented Sep 22, 2022

Wondertan commented Sep 22, 2022

rootulp commented Sep 22, 2022

Wondertan commented Sep 22, 2022

rootulp commented Sep 22, 2022

rootulp commented Sep 22, 2022 •

edited

Loading

Wondertan commented Sep 23, 2022

rootulp commented Sep 23, 2022

rootulp commented Sep 29, 2022

rootulp commented Oct 7, 2022

Wondertan commented Oct 11, 2022

rootulp commented Oct 13, 2022

Wondertan left a comment

chore!: upgrade to celestia-app v0.7.0 #1147

chore!: upgrade to celestia-app v0.7.0 #1147

Conversation

rootulp commented Sep 21, 2022 • edited Loading

codecov-commenter commented Sep 22, 2022 • edited Loading

Codecov Report

rootulp commented Sep 22, 2022

Wondertan commented Sep 22, 2022

rootulp commented Sep 22, 2022

Wondertan commented Sep 22, 2022

rootulp commented Sep 22, 2022

rootulp commented Sep 22, 2022 • edited Loading

Wondertan commented Sep 23, 2022

rootulp commented Sep 23, 2022

rootulp commented Sep 29, 2022

rootulp commented Oct 7, 2022

Wondertan commented Oct 11, 2022

rootulp commented Oct 13, 2022

Wondertan left a comment

Choose a reason for hiding this comment

rootulp commented Sep 21, 2022 •

edited

Loading

codecov-commenter commented Sep 22, 2022 •

edited

Loading

rootulp commented Sep 22, 2022 •

edited

Loading