Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump celestia-app v0.10.0 #1389

Merged

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Nov 23, 2022

Overview

This PR is a draft until we finish the release for v0.10.0 of the app. The only difference between v0.10.0 and the last release candidate is strictly a single commit that might help CI, and a (soon) name change.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Closes #1384

@evan-forbes evan-forbes self-assigned this Nov 23, 2022
@evan-forbes evan-forbes added the kind:deps Pull requests that update a dependency file label Nov 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #1389 (fa84748) into main (31434cb) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
+ Coverage   56.04%   56.07%   +0.03%     
==========================================
  Files         188      188              
  Lines       11550    11552       +2     
==========================================
+ Hits         6473     6478       +5     
+ Misses       4441     4439       -2     
+ Partials      636      635       -1     
Impacted Files Coverage Δ
core/testing.go 84.67% <100.00%> (+0.22%) ⬆️
share/eds/byzantine/bad_encoding.go 66.00% <0.00%> (-3.00%) ⬇️
share/ipld/get.go 93.41% <0.00%> (+1.23%) ⬆️
header/core/listener.go 58.49% <0.00%> (+5.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evan-forbes
Copy link
Member Author

evan-forbes commented Nov 30, 2022

Do the integration tests normally fail with this, or is this new? It seems to do so pretty consistently. Are the swamp tests being ran in parallel?

Error:      	Received unexpected error:
        	            	failed to listen on 127.0.0.1:36657: listen tcp 127.0.0.1:36657: bind: address already in use
        	Test:       	TestSyncFullWithBridge

@evan-forbes evan-forbes marked this pull request as ready for review November 30, 2022 13:58
@Wondertan
Copy link
Member

@evan-forbes, does it fails consistently locally?

@evan-forbes
Copy link
Member Author

oh shoot, it does whoops one sec

@evan-forbes
Copy link
Member Author

blocked on #1410

@evan-forbes evan-forbes force-pushed the evan/bump-celestia-app-v0.10.0 branch from adec81f to 9e22d1c Compare December 2, 2022 20:33
@evan-forbes
Copy link
Member Author

alllll grreeeeennnn no one touch anything!

vgonkivs
vgonkivs previously approved these changes Dec 5, 2022
Wondertan
Wondertan previously approved these changes Dec 5, 2022
walldiss
walldiss previously approved these changes Dec 5, 2022
core/testing.go Outdated Show resolved Hide resolved
nodebuilder/tests/swamp/swamp.go Outdated Show resolved Hide resolved
@evan-forbes evan-forbes dismissed stale reviews from walldiss, Wondertan, and vgonkivs via a531f6b December 5, 2022 15:46
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ @evan-forbes

go.mod Show resolved Hide resolved
@Wondertan
Copy link
Member

Ok, I merging this

@Wondertan Wondertan enabled auto-merge (squash) December 6, 2022 16:46
@Wondertan Wondertan merged commit fbfd45b into celestiaorg:main Dec 6, 2022
@Wondertan Wondertan deleted the evan/bump-celestia-app-v0.10.0 branch December 6, 2022 16:46
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deps: bump core version
7 participants