Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notify to v0.9.3 to fix deprecation warning on MacOS 13. #2222

Closed
wants to merge 1 commit into from

Conversation

adlerjohn
Copy link
Member

@adlerjohn adlerjohn commented May 17, 2023

Overview

Running make build on MacOS 13 (Ventura) gives

$ make build
--> Building Celestia
# github.com/rjeczalik/notify
cgo-gcc-prolog:217:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here

Fix this by updating rjeczalik/notify to v0.9.3 as recommended here: ethereum/go-ethereum#26168 (comment). Updating go-ethereum might be an alternative but would be much more cumbersome.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@adlerjohn adlerjohn added the kind:deps Pull requests that update a dependency file label May 17, 2023
@adlerjohn adlerjohn self-assigned this May 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2222 (7e7650d) into main (e8ffd64) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #2222   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files         216      216           
  Lines       14130    14142   +12     
=======================================
+ Hits         7886     7894    +8     
- Misses       5454     5459    +5     
+ Partials      790      789    -1     
Impacted Files Coverage Δ
share/availability/discovery/discovery.go 73.85% <0.00%> (-2.40%) ⬇️
share/availability/discovery/metrics.go 47.05% <57.14%> (+0.63%) ⬆️
share/availability/discovery/backoff.go 86.79% <100.00%> (+1.07%) ⬆️

... and 2 files with indirect coverage changes

@Wondertan
Copy link
Member

@adlerjohn, is this RFR?

@adlerjohn adlerjohn changed the title Update notify to v0.9.3 to fix deprecation warning on MocOS 13. Update notify to v0.9.3 to fix deprecation warning on MacOS 13. Jun 28, 2023
@adlerjohn
Copy link
Member Author

no longer needed as of #2253 which did the much more cumbersome job of bumping go-ethereum

@adlerjohn adlerjohn closed this Jun 28, 2023
@adlerjohn adlerjohn deleted the adlerjohn/macos-fix-deprecated branch August 7, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants