feat!: unify the blob.Proof and the CommitmentProof #3821
Conversation
rach-id
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
rach-id
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature_branch_blob_proof #3821 +/- ##
============================================================
Coverage ? 45.40%
============================================================
Files ? 313
Lines ? 21753
Branches ? 0
============================================================
Hits ? 9877
Misses ? 10856
Partials ? 1020 ☔ View full report in Codecov by Sentry. |
| // Note: this method can be deprecated because it's doing processing that can | ||
| // be done locally. |
There was a problem hiding this comment.
Since our API operates with header's height, deprecating this method requires users to download the header to get the hash.
So, I agree that we can deprecate this method in favour of proof public validate methods but only after migration from heights to hashes.
There was a problem hiding this comment.
cool, we can create an issue for it
There was a problem hiding this comment.
I think we had somewhere such an issue or task inside the EPIC. I will double-check and close the issue in this case
Closes #3516 and #3582
Note: added couple notes for reviewers concerning the error handling