feat(store): Add HasQ4ByHash method on store #4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
area:core_and_app
renaynay
requested review from
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
|
Add test util to store pkg |
auto-merge was automatically disabled
January 20, 2025 09:38
Pull request was converted to draft
renaynay
changed the title
cristaloleg
reviewed
Jan 22, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4035 +/- ##
==========================================
+ Coverage 44.83% 44.89% +0.05%
==========================================
Files 265 308 +43
Lines 14620 22488 +7868
==========================================
+ Hits 6555 10096 +3541
- Misses 7313 11308 +3995
- Partials 752 1084 +332 ☔ View full report in Codecov by Sentry. |
Wondertan
approved these changes
Jan 22, 2025
vgonkivs
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds utility method to check if store has the .q4 file of a given hash.
Adds tests to core pkg to ensure that blocks outside sampling window do not have the Q4 file stored.