Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade celestia-app to latest version #648

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

renaynay
Copy link
Member

Update celestia-app dep to latest.

Closes #629 and #615 (outdated).

@renaynay renaynay added the kind:misc Attached to miscellaneous PRs label Apr 26, 2022
@renaynay renaynay requested a review from liamsi as a code owner April 26, 2022 11:31
@renaynay renaynay self-assigned this Apr 26, 2022
@renaynay renaynay requested a review from Wondertan as a code owner April 26, 2022 11:31
@renaynay renaynay requested a review from vgonkivs April 26, 2022 11:31
@renaynay
Copy link
Member Author

@vgonkivs do you mind checking for proper rmst2d uses?

Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional changes look fine.

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@renaynay renaynay requested a review from adlerjohn April 27, 2022 10:27
@codecov-commenter
Copy link

Codecov Report

Merging #648 (880104c) into main (804c1d9) will increase coverage by 0.20%.
The diff coverage is 91.30%.

❗ Current head 880104c differs from pull request most recent head a294cc9. Consider uploading reports for the commit a294cc9 to get more accurate results

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   61.57%   61.78%   +0.20%     
==========================================
  Files          95       97       +2     
  Lines        5020     5055      +35     
==========================================
+ Hits         3091     3123      +32     
- Misses       1603     1607       +4     
+ Partials      326      325       -1     
Impacted Files Coverage Δ
service/header/header.go 36.70% <0.00%> (-1.45%) ⬇️
ipld/retriever.go 89.55% <89.55%> (ø)
service/share/full_availability.go 93.75% <91.66%> (-6.25%) ⬇️
ipld/read.go 77.94% <100.00%> (-7.25%) ⬇️
ipld/retriever_quadrant.go 100.00% <100.00%> (ø)
service/share/light_availability.go 91.89% <100.00%> (+0.22%) ⬆️
service/share/share.go 80.26% <100.00%> (+0.26%) ⬆️
das/daser.go 70.58% <0.00%> (-2.62%) ⬇️
service/header/core_listener.go 57.69% <0.00%> (+5.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2488e...a294cc9. Read the comment docs.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renaynay renaynay merged commit ae6e3c5 into celestiaorg:main Apr 27, 2022
@renaynay renaynay deleted the cel-app-upgrade branch April 27, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:misc Attached to miscellaneous PRs
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants