Initial consensus rules #89
Conversation
adlerjohn
added
documentation
|
Since the last review, the major change has been reverting the change that were previously made for #86 in 6d9648a as per #89 (comment), and adding the corresponding state transition rules for the transaction that pays for padding. |
GRAFFITI_BYTES -> MAX_GRAFFITI_BYTES Co-authored-by: Ismail Khoffi <[email protected]>
|
|
||
| ### `block.header` | ||
|
|
||
| The [block header](./data_structures.md#header) `block.header` (`header` for short) is the first thing that is downloaded from the new block, and commits to everything inside the block in some way. For previous block `prev` (if `prev` is not known, then the block is ignored), and previous block header `prev.header`, the following checks must be `true`: |
There was a problem hiding this comment.
The block header
block.header(headerfor short) is the first thing that is downloaded from the new block
If it is actively downloaded or received (e.g. via some gossip routine etc) should go in the network spec. Maybe say "processed"; this implies that you have it at hand.
There was a problem hiding this comment.
The plan is actually to move that entire paragraph to the networking section, since a node won't even accept a block header unless it passes those checks.
| #### SignedTransactionDataPayForPadding | ||
|
|
||
| 1. `tx.type` == [`TransactionType.PayForPadding`](./data_structures.md#signedtransactiondata). | ||
| 1. The `ceil(tx.messageSize / SHARE_SIZE)` shares starting at index `wrappedTransactions.messageStartIndex` must: | ||
| 1. Have namespace ID `tx.messageNamespaceID`. | ||
|
|
||
| Apply the following to the state: | ||
|
|
||
| ``` | ||
| ``` |
There was a problem hiding this comment.
Shouldn't we remove this type together with the paragraph under Caveats?
(https://github.com/lazyledger/lazyledger-specs/pull/89/files#r531078625)
There was a problem hiding this comment.
I don't want to be overzealous with the scope of this PR, so I filed #98 to follow up on how padding should be handled. For now I'd rather just leave the PayForPadding tx type as it was. #89 (comment)
adlerjohn
dismissed
musalbas’s stale review
Approved, issues filed for change requests.
Initial pass of the consensus rules, covering block structure and state transitions.