This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
consensus
labels
Dec 2, 2020
Closed
liamsi
reviewed
Dec 8, 2020
liamsi
reviewed
Dec 8, 2020
liamsi
reviewed
Dec 8, 2020
liamsi
reviewed
Dec 8, 2020
liamsi
reviewed
Dec 8, 2020
Co-authored-by: Ismail Khoffi <[email protected]>
liamsi
reviewed
Dec 8, 2020
liamsi
reviewed
Dec 8, 2020
liamsi
reviewed
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't fully familiarize myself with eip-1559 but the changes make sense. Also, I didn't yet validate each check and each state transition. The ones I've checked make sense so far and besides some minor comments the PR looks good to me.
liamsi
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we'll give this a second and much more detailed pass, when triying to implement this (e.g. as a cosmos module - this discussion is kinda related btw: cosmos/cosmos-sdk#7347)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
consensus
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the rationale document for rationale: https://github.com/lazyledger/lazyledger-specs/blob/adlerjohn-fees/rationale/fees.md
Add consensus rules and data structures for paying fees.