use celestiaorg instead of lazyledger #28

evan-forbes · 2021-08-26T20:38:01Z

Description

replaces lazyledger-core with celestia-core and updates to the latest commit of celestia-core

blocked by: #522
closes: #26

Bidon15 · 2021-08-27T09:44:48Z

simapp/simd/cmd/testnet.go

@@ -116,7 +116,7 @@ func InitTestnet(
 ) error {

 	if chainID == "" {
-		chainID = "chain-" + tmrand.NewRand().Str(6)
+		chainID = "chain-" + tmrand.Str(6)


I'm just a little bit curios on why do we decide to drop NewRand()? 😶‍🌫️
As latest cosmos-sdk repo is still using NewRand() in their testnet file

good question, check out celestiaorg/celestia-core#284

testutil/network/network.go

Bidon15 · 2021-08-27T09:54:25Z

third_party/proto/tendermint/abci/types.proto

@@ -370,7 +370,7 @@ message Evidence {
  ];
  // Total voting power of the validator set in case the ABCI application does
  // not store historical validators.
-  // https://github.com/lazyledger/lazyledger-core/issues/4581
+  // https://github.com/celestiaorg/celestia-core/issues/4581


I guess it's better to leave tendermint here as we will be facing 404 error, if navigating with this link

nice catch!! resolved in 21f0b78

x/evidence/types/query.pb.go

x/ibc/light-clients/07-tendermint/types/tendermint.pb.go

…use master later)

evan-forbes · 2021-08-30T20:12:24Z

go.mod

-replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.2-alpha.regen.4
+replace (
+	github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.2-alpha.regen.4
+	github.com/golang/mock => github.com/golang/mock v1.4.4
+	google.golang.org/grpc => google.golang.org/grpc v1.33.2
+)


had to use older versions of golang/mock and grpc to get tests to pass.

upstream sdk still uses v1.33.2 of grpc due to the same bugs encountered here ref Should be fixed in a future update.

As for golang/mock, I think an updated version of the sdk will accommodate the updated version, so we can remove that replace when we update.

evan-forbes · 2021-08-30T20:14:05Z

go.mod

-	github.com/btcsuite/btcutil v1.0.2
+	github.com/btcsuite/btcd v0.22.0-beta
+	github.com/btcsuite/btcutil v1.0.3-0.20201208143702-a53e38424cce
+	github.com/celestiaorg/celestia-core v0.0.1-mvp-das-lightclient.0.20210830200007-52e4383a7266


I'll also update this to use the master branch as soon as we merge #522

evan-forbes · 2021-08-30T20:18:30Z

go-lint is expected to fail due to using standard lib instead of tendermint one (see ref.

Co-authored-by: Nguyen Nhu Viet <[email protected]>

codecov-commenter · 2021-08-30T20:38:58Z

Codecov Report

Merging #28 (21f0b78) into master (3addd7f) will increase coverage by 0.98%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   61.90%   62.89%   +0.98%     
==========================================
  Files         609      609              
  Lines       35108    40392    +5284     
==========================================
+ Hits        21735    25405    +3670     
- Misses      11088    12664    +1576     
- Partials     2285     2323      +38

Impacted Files	Coverage Δ
baseapp/abci.go	`59.86% <ø> (+1.78%)`	⬆️
baseapp/baseapp.go	`76.27% <ø> (-1.02%)`	⬇️
baseapp/grpcrouter.go	`87.50% <ø> (+1.45%)`	⬆️
baseapp/grpcrouter_helpers.go	`31.81% <ø> (+0.23%)`	⬆️
baseapp/params.go	`100.00% <ø> (ø)`
baseapp/test_helpers.go	`63.15% <ø> (+6.01%)`	⬆️
client/broadcast.go	`53.75% <ø> (+1.69%)`	⬆️
client/cmd.go	`60.33% <ø> (+1.23%)`	⬆️
client/context.go	`65.18% <ø> (+5.96%)`	⬆️
client/flags/flags.go	`21.15% <ø> (-0.13%)`	⬇️
... and 721 more

evan-forbes · 2021-08-31T11:46:39Z

also, the liveness test is passing for me locally, so I don't think it's worth debugging the CI atm. If it still fails after we update to the latest version of the sdk, then we can debug it then.

test results

Restarting random docker container simdnode1
Number of Blocks: 6
Number of Blocks: 7
Number of Blocks: 8
Number of Blocks: 8
Number of Blocks: 9
Number of Blocks: 10
Number of Blocks: 11
Number of Blocks: 12
Number of Blocks: 13
Number of Blocks: 14
Restarting random docker container simdnode3
Number of Blocks: 15
Number of Blocks: 16
Number of Blocks: 17
Number of Blocks: 18
Number of Blocks: 19
Number of Blocks: 20
Number of Blocks: 21
Number of Blocks: 22
Number of Blocks: 23
Number of Blocks: 24
Restarting random docker container simdnode3
Number of Blocks: 25
Number of Blocks: 26
Number of Blocks: 26
Number of Blocks: 27
Number of Blocks: 28
Number of Blocks: 29
Number of Blocks: 30
Number of Blocks: 31
Number of Blocks: 32
Number of Blocks: 33
Restarting random docker container simdnode1
Number of Blocks: 34
Number of Blocks: 35
Number of Blocks: 36
Number of Blocks: 37
Number of Blocks: 38
Number of Blocks: 39
Number of Blocks: 40
Number of Blocks: 41
Number of Blocks: 42
Number of Blocks: 43
Restarting random docker container simdnode0
Number of Blocks: 43
Number of Blocks: 44
Number of Blocks: 45
Number of Blocks: 46
Number of Blocks: 46
Number of Blocks: 47
Number of Blocks: 48
Number of Blocks: 49
Number of Blocks: 50
Number of Blocks: 51
Number of blocks reached. Success!

evan-forbes · 2021-08-31T13:31:02Z

I think we can just update to the latest version of the sdk and see if they fixed the links. leaving a ref #27 to remind myself

Bidon15 · 2021-08-31T14:00:31Z

Let's hope that it will self-cure after the update 🤞 as we will be doomed to do this manual labour omt 😓

Bidon15

👍

tzdybal

LGTM

use celestiaorg instead of lazyledger

66a4968

evan-forbes requested review from Bidon15, Wondertan and renaynay August 26, 2021 20:38

evan-forbes self-assigned this Aug 26, 2021

evan-forbes marked this pull request as draft August 26, 2021 20:41

try some changes to fix go mod

2759ba8

evan-forbes mentioned this pull request Aug 27, 2021

Add unused code back in to preserve compatibility with the sdk celestiaorg/celestia-core#522

Merged

Bidon15 reviewed Aug 27, 2021

View reviewed changes

evan-forbes added 2 commits August 30, 2021 14:59

use older version of golang/mock in order to get tests to pass

94ed596

use the branch of celestia-core that restores some unused code (will …

598e1df

…use master later)

evan-forbes commented Aug 30, 2021

View reviewed changes

evan-forbes and others added 2 commits August 30, 2021 15:22

regenerate proto files

45bbca6

fix links

21f0b78

Co-authored-by: Nguyen Nhu Viet <[email protected]>

evan-forbes marked this pull request as ready for review August 30, 2021 20:38

Bidon15 previously approved these changes Aug 31, 2021

View reviewed changes

use latest commit of celestia-core

1e200b6

evan-forbes dismissed Bidon15’s stale review via 1e200b6 August 31, 2021 14:42

Bidon15 previously approved these changes Aug 31, 2021

View reviewed changes

add version that was somehow missing?

4a35418

evan-forbes dismissed Bidon15’s stale review via 4a35418 August 31, 2021 15:06

Bidon15 approved these changes Aug 31, 2021

View reviewed changes

evan-forbes requested a review from tzdybal September 1, 2021 14:21

tzdybal approved these changes Sep 1, 2021

View reviewed changes

evan-forbes merged commit 42cf598 into master Sep 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use celestiaorg instead of lazyledger #28

use celestiaorg instead of lazyledger #28

evan-forbes commented Aug 26, 2021 •

edited

Loading

Bidon15 Aug 27, 2021

evan-forbes Aug 30, 2021

Bidon15 Aug 27, 2021

evan-forbes Aug 30, 2021

evan-forbes Aug 30, 2021

evan-forbes Aug 30, 2021

evan-forbes commented Aug 30, 2021

codecov-commenter commented Aug 30, 2021 •

edited

Loading

evan-forbes commented Aug 31, 2021 •

edited

Loading

evan-forbes commented Aug 31, 2021 •

edited

Loading

Bidon15 commented Aug 31, 2021

Bidon15 left a comment

tzdybal left a comment

use celestiaorg instead of lazyledger #28

use celestiaorg instead of lazyledger #28

Conversation

evan-forbes commented Aug 26, 2021 • edited Loading

Description

Bidon15 Aug 27, 2021

Choose a reason for hiding this comment

evan-forbes Aug 30, 2021

Choose a reason for hiding this comment

Bidon15 Aug 27, 2021

Choose a reason for hiding this comment

evan-forbes Aug 30, 2021

Choose a reason for hiding this comment

evan-forbes Aug 30, 2021

Choose a reason for hiding this comment

evan-forbes Aug 30, 2021

Choose a reason for hiding this comment

evan-forbes commented Aug 30, 2021

codecov-commenter commented Aug 30, 2021 • edited Loading

Codecov Report

evan-forbes commented Aug 31, 2021 • edited Loading

evan-forbes commented Aug 31, 2021 • edited Loading

Bidon15 commented Aug 31, 2021

Bidon15 left a comment

Choose a reason for hiding this comment

tzdybal left a comment

Choose a reason for hiding this comment

evan-forbes commented Aug 26, 2021 •

edited

Loading

codecov-commenter commented Aug 30, 2021 •

edited

Loading

evan-forbes commented Aug 31, 2021 •

edited

Loading

evan-forbes commented Aug 31, 2021 •

edited

Loading