chore: Create cosmos-sdk branch that uses Celestia and is based on v.0.44.0 of upstream #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from upstream (after v0.40.0)
* manually swith to lazyledger-core * manually replace tendermint with lazyledger-core in all proto files update proto to lazyleder-core * baseapp: delete old tendermint abci method * baseapp: partially implement new ABCI method baseapp: add todo for PreprocessTxs docs * bubble new error, switch to field instead of method, and replace old tendermint function with std lib go mod tidy * server: fixed bug that stops config from being unmarshalled by viper * fix tag to allow for proper unmarshalling * regenerate proto bindings * use the latest version of lazyledger-core to fix the grpc versioning issue causing panics * add template test for the new abci method finish doc sentence * update changelog * running gofmt -s
* use celestiaorg instead of lazyledger * try some changes to fix go mod * use older version of golang/mock in order to get tests to pass * use the branch of celestia-core that restores some unused code (will use master later) * regenerate proto files * fix links Co-authored-by: Nguyen Nhu Viet <[email protected]> * use latest commit of celestia-core * add version that was somehow missing? Co-authored-by: Nguyen Nhu Viet <[email protected]>
cosmos#10189) (cosmos#10253) * fix: removed potential sources of non-determinism in upgrades (cosmos#10189) forced deterministic iteration order in upgrade migrations, x/upgrade and store during upgrades Co-authored-by: Robert Zaremba <[email protected]> (cherry picked from commit f757c90) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Tomas Tauber <[email protected]> Co-authored-by: Robert Zaremba <[email protected]>
* CL: create v0.44.1 * Add releaes notes * Update date * Update RELEASE_NOTES.md Co-authored-by: Robert Zaremba <[email protected]> * mark abci.QueryRequest as bugfix Co-authored-by: Robert Zaremba <[email protected]>
evan-forbes
changed the title
This was referenced Sep 29, 2021
Pull changes from upstream and use version of celestia-core that is based on tendermint v0.34.12
#33
Merged
|
There has been a patch release btw: https://github.com/cosmos/cosmos-sdk/releases/tag/v0.44.1 |
|
Also, I'd like our branches from which we create the releases from to match those with upstream, e.g.: https://github.com/cosmos/cosmos-sdk/tree/release/v0.44.x That way it is clear where the version we are using originated from, and which version our release is based on. Also, we can pull updates right from the original branch. Same for tendermint. Maybe we should capture this in some markdown file somehow. |
evan-forbes
force-pushed
the
evan/celestia-v0.44.0-base
branch
from
f1d7264 to
9f78578
Compare
evan-forbes
changed the base branch from
evan/upstream-v0.44.0-base
to
release/v0.44.x-celestia
evan-forbes
force-pushed
the
evan/celestia-v0.44.0-base
branch
from
9f78578 to
aada8f6
Compare
sounds good! 👍 switched the base of this branch to the latest from upstream v.044.x and also updated this PR branch, so we are now using the patch version along with appropriate naming. |
13 tasks
liamsi
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
celestia-app will need a stable version of the sdk to point to, therefore we will also need a stable release branch of the sdk that uses celestia-core instead of tendermint. This PR introduces the minimum changes necessary to do just that.
part of #27