Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add workflow to pull from upstream master #35

Closed
wants to merge 3 commits into from

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Oct 12, 2021

Description

This PR introduced a workflow that pulls changes from upstream and the v0.44.x release branch twice a week.

This PR is blocked by having a github repository secret that is named PULL_UPSTREAM that has permissions for repo read and write, along with access to workflows.

we can see this bot in action on this fork

part of #528

@evan-forbes evan-forbes self-assigned this Oct 12, 2021
@evan-forbes evan-forbes changed the title add workflow to pull from upstream master chore: add workflow to pull from upstream master Oct 12, 2021
@evan-forbes evan-forbes marked this pull request as ready for review October 12, 2021 21:19
@liamsi
Copy link
Member

liamsi commented Oct 12, 2021

This PR is blocked by having a github repository secret that is named PULL_UPSTREAM that has permissions for repo read and write, along with access to workflows.

I need to double-check how to do this. I'm fine with giving this the proper perms as long as it can't write to protected branches and has to open PRs like everyone else.

@evan-forbes
Copy link
Member Author

evan-forbes commented Oct 16, 2021

see comment

switching to a draft until we decide

@evan-forbes evan-forbes marked this pull request as draft October 16, 2021 21:58
@evan-forbes
Copy link
Member Author

This bot would actually be worth it, as we have significantly fewer changes here than in celestia-core, so there shouldn't be many conflicts that require fixing manually. Still leaving as a draft for now, as I won't have time to fix this until January.

Also, we still need to make a decision as to whether or not we are ok with giving write permissions to a bot.

@liamsi
Copy link
Member

liamsi commented Dec 3, 2021

Thinking about it, we could also just have a bot, that simply opens an issue if there was another SDK release maybe. Just so we will be notified. Same with the core repo. That wouldn't require any extra perms besides opening issues (maybe even a slack bot would be ok otherwise). It would be good if were at least always on par with the latest stable tendermint release and the corresponding SDK.

I think the main/master branch can just be updated manually on-demand:
image

@adlerjohn
Copy link
Member

Can we close this and file an issue for the above?

@liamsi liamsi closed this Apr 27, 2022
@liamsi liamsi deleted the evan/pull-from-upstream branch April 27, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants