Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(mergify): upgrade configuration to current format #419

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 22, 2024

Hey there! 👋

We've noticed that your Mergify configuration is using some deprecated fields.

No worries—we've got your back! This automated PR updates your config to align with the newest standards, ensuring everything keeps running smoothly.

Do not procrastinate! You must upgrade your configuration before 2025-01-31, otherwise your configuration will stop working.

What's Changed?

  • pull_request_rules → actions → queue → commit_message_template: To ease the configuration of queues, we are moving this attribute in the queue_rules definition. (deadline: 2025-01-31)
  • pull_request_rules → actions → queue → merge_method: To ease the configuration of queues, we are moving this attribute in the queue_rules definition. (deadline: 2025-01-31)

Why This Matters

Keeping your configuration up-to-date means you'll benefit from the latest features and improvements Mergify has to offer. Plus, it helps prevent any unexpected hiccups down the road.

Got Questions? We've Got Answers! 🙌

Is this update safe to merge?

Absolutely! We've made sure the changes are compatible with your current setup. Your workflows should continue to work just as before—if not better!

Do I need to do anything special after merging?

Nope! Just merge this PR, and you're all set. If you have any custom configurations, it's a good idea to give them a quick look to ensure everything's in order.

What if I run into issues or have concerns?

We're here to help! Feel free to reach out to our support team anytime.

Thanks for being awesome and keeping your configuration up-to-date! If you have any thoughts or need a hand, don't hesitate to let us know.

Happy merging! 🎉

@mergify mergify bot requested a review from a team as a code owner November 22, 2024 13:30
@mergify mergify bot requested review from rootulp and ninabarbakadze and removed request for a team November 22, 2024 13:30
.mergify.yml Outdated
Comment on lines 7 to 11
merge_conditions:
- "#approved-reviews-by>1"
merge_method: squash
commit_message_template: |
{{ title }} (#{{ number }})
{{ body }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks suspect because this was moved from under the automerge thing to the queue rules.

Since GitHub now has automerge, we don't use automerge from mergify so I'm inclined to delete that setting entirely.

@mergify mergify bot closed this Nov 22, 2024
@rootulp rootulp reopened this Nov 22, 2024
@mergify mergify bot force-pushed the mergify/configuration-deprecated-update branch from 12fa277 to 2eead34 Compare November 27, 2024 22:12
@rootulp
Copy link
Collaborator

rootulp commented Nov 27, 2024

Ugh mergify overwrote my commit. Closing this b/c I don't think we need it.

@rootulp rootulp closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant