Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest ABCI++ version of core and add the new methods to baseapp #63

Merged
merged 4 commits into from
Mar 31, 2022

Conversation

evan-forbes
Copy link
Member

Description

v0.44.x based cosmos-sdk branch that is modified to use celestia-core master and the two new methods from ABCI++

@evan-forbes evan-forbes self-assigned this Feb 16, 2022
@evan-forbes
Copy link
Member Author

evan-forbes commented Feb 16, 2022

the remaining failing test is expected, as we don't yet support returning proofs for large transactions

TestIntegrationTestSuite/TestCLIQueryTxsCmdByEvents/fee_event_happy_case (0.00s)
            suite.go:483: 
                	Error Trace:	suite.go:483
                	            				suite.go:77
                	Error:      	Received unexpected error:
                	            	transaction spanned more than two shares, this is not yet supported

tbc, the transaction is still being committed to and applies the appropriate state changes, we just can't yet prove that it was committed in a block as the tx is greater than 248 bytes. We have an issue for this in #621

@adlerjohn
Copy link
Member

What's the status of this?

@evan-forbes
Copy link
Member Author

What's the status of this?

its currently blocked by #631, but other than that it's good to go

@adlerjohn
Copy link
Member

Can we convert to draft until unblocked?

@evan-forbes evan-forbes marked this pull request as draft February 27, 2022 02:46
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged after 631 is merged 🙏🏼

@evan-forbes evan-forbes marked this pull request as ready for review March 30, 2022 01:15
@evan-forbes
Copy link
Member Author

for some reason, switching from a specific commit to the release tag broke one of the CI tests that compiles the proto files. I can compile the proto files locally fine, so still looking into this

@evan-forbes
Copy link
Member Author

evan-forbes commented Mar 31, 2022

created #81 so we can fix the CI later, as the issue is only in CI and this is blocking the rest of the ABCI++ changes

@evan-forbes evan-forbes merged commit bf7e294 into release/v0.44.x-celestia Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants