-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use latest ABCI++ version of core and add the new methods to baseapp #63
use latest ABCI++ version of core and add the new methods to baseapp #63
Conversation
the remaining failing test is expected, as we don't yet support returning proofs for large transactions
tbc, the transaction is still being committed to and applies the appropriate state changes, we just can't yet prove that it was committed in a block as the tx is greater than 248 bytes. We have an issue for this in #621 |
What's the status of this? |
its currently blocked by #631, but other than that it's good to go |
Can we convert to draft until unblocked? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged after 631 is merged 🙏🏼
for some reason, switching from a specific commit to the release tag broke one of the CI tests that compiles the proto files. I can compile the proto files locally fine, so still looking into this |
created #81 so we can fix the CI later, as the issue is only in CI and this is blocking the rest of the ABCI++ changes |
Description
v0.44.x based cosmos-sdk branch that is modified to use celestia-core master and the two new methods from ABCI++