Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change instances of "qgb" to "Blobstream", update workflow #1115

Merged
merged 26 commits into from
Oct 17, 2023

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Oct 5, 2023

Overview

This PR resolves #1113

  • update non-programmatic instances of "QGB" and "Quantum Gravity Bridge" to "Blobstream"
  • update programmatic instances of qgb to new name, once renamed
  • remove mentions of Celestiums and replace with "layer 2 (L2)" and "layer 2s (L2s)" Resolves chore: remove celestium from documentation #1114
  • update workflow to pull in source from orchestrator-relayer repository with correct names, i.e. blobstream-xxx.md
  • add new diagrams draft
  • add final versions of new diagrams

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein self-assigned this Oct 5, 2023
@jcstein jcstein added the documentation Improvements or additions to documentation label Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-1115/
on branch gh-pages at 2023-10-17 14:38 UTC

@jcstein jcstein added the unreleased-app/core Unreleased Core and App changes label Oct 5, 2023
@jcstein jcstein changed the title chore: change nonprogrammatic instances of "qgb" to "Blobstream", update workflow chore: change instances of "qgb" to "Blobstream", update workflow Oct 6, 2023
@jcstein jcstein requested review from adlerjohn and rach-id October 11, 2023 20:39
@jcstein jcstein marked this pull request as ready for review October 11, 2023 20:45
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass looks good 👍 👍

Left some cosmetic comments to be addressed. Then, I will make a second pass on the overview

docs/community/cohort-one-content.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-binary.mdx Show resolved Hide resolved
docs/nodes/blobstream-binary.mdx Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Show resolved Hide resolved
docs/nodes/consensus-node.mdx Outdated Show resolved Hide resolved
@jcstein jcstein requested a review from rach-id October 13, 2023 14:50
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
Comment on lines 81 to 82
Ethereum's L2 contract updates its state, it checks with Blobstream to confirm
that data's presence on Celestia. In contrast, a DAC would rely on attestations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks with Blobstream to confirm that data's presence on Celestia

How this? I am not aware of this happening or I don't get this part

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworked in ba3b632

Comment on lines 90 to 91
computation-centric. The scalability costs of a DAC would largely hinge on its
specific design, but it may not achieve the same balance as Blobstream.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworked in ba3b632

@jcstein jcstein requested a review from rach-id October 16, 2023 14:36
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
docs/nodes/blobstream-intro.md Outdated Show resolved Hide resolved
@jcstein jcstein merged commit ed5f701 into main Oct 17, 2023
@jcstein jcstein deleted the jcs/blobstream branch October 17, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation unreleased-app/core Unreleased Core and App changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: remove celestium from documentation chore: change qgb -> blobstream
3 participants