Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: blobstream updates #1261

Merged
merged 14 commits into from
Nov 20, 2023
Merged

chore: blobstream updates #1261

merged 14 commits into from
Nov 20, 2023

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Nov 10, 2023 •
edited
Loading

Overview

  1. Updates the nodes/blobstream-binary page, which combines the current blobstream-intro and blobstream-binary pages
  2. Updates the developers/blobstream page, moving more general overview information to the developers/blobstream page
  3. Resolves Blobstream docs feedback #1275 - addressing points 1-5, and will pull in changes from orchestrator-relayer repo when they're made there
  4. Resolves making figures consistent in the blobstream intro #1271 - removing old diagrams
  • update from arabica to mocha
  • update contract addresses

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-20 20:53 UTC

@jcstein jcstein mentioned this pull request Nov 10, 2023
Closed
@jcstein jcstein changed the title chore: update to mocha for blobstream chore: blobstream updates Nov 17, 2023
@jcstein jcstein requested review from rootulp and staheri14 November 17, 2023 21:13
@jcstein jcstein mentioned this pull request Nov 17, 2023
Closed
@jcstein jcstein marked this pull request as ready for review November 20, 2023 18:57
@jcstein jcstein added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 20, 2023
rach-id
rach-id approved these changes Nov 20, 2023
View reviewed changes
nodes/blobstream-binary.md Outdated Show resolved Hide resolved
rootulp
rootulp reviewed Nov 20, 2023
View reviewed changes
.vitepress/constants/constants.js Outdated Show resolved Hide resolved
developers/blobstream.md Outdated Show resolved Hide resolved
developers/blobstream.md Outdated Show resolved Hide resolved
nodes/blobstream-binary.md Outdated Show resolved Hide resolved
nodes/blobstream-bootstrapper.md Show resolved Hide resolved
nodes/blobstream-bootstrapper.md Show resolved Hide resolved
nodes/blobstream-bootstrapper.md Outdated Show resolved Hide resolved
nodes/blobstream-bootstrapper.md Outdated Show resolved Hide resolved
nodes/blobstream-bootstrapper.md Outdated Show resolved Hide resolved
nodes/blobstream-orchestrator.md Outdated Show resolved Hide resolved
@jcstein
Copy link
Member Author

jcstein commented Nov 20, 2023

celestiaorg/orchestrator-relayer#606

@jcstein jcstein merged commit 441b20a into main Nov 20, 2023
2 checks passed
@jcstein jcstein deleted the jcs/blobstream-update branch November 20, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp left review comments

@evan-forbes evan-forbes evan-forbes approved these changes

@rach-id rach-id rach-id approved these changes

@staheri14 staheri14 Awaiting requested review from staheri14

Assignees

@jcstein jcstein

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blobstream docs feedback making figures consistent in the blobstream intro
4 participants
@jcstein @rootulp @rach-id @evan-forbes