fix(p2p/exchange): Remove peer blocking from head request #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the exchange will block peers for giving a bad header that does not pass the
Verify
check (unless it is aSoftFailure
). Unless we introduce another field inside ofVerifyError
to indicate to the caller whether the error was severe enough to warrant blocking, we shouldn't blanket block for verify errors as a good peer that sends a slightly outdated header will get banned.(this is currently observable on
arabica
- have not tested on mocha yet)Moral of the story: do not prematurely implement blocking behaviour.