fix(p2p/exchange): Remove peer blocking from head request #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
tzdybal,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
Codecov Report
@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 69.20% 69.16% -0.05%
==========================================
Files 37 37
Lines 2939 2938 -1
==========================================
- Hits 2034 2032 -2
Misses 756 756
- Partials 149 150 +1
|
vgonkivs
approved these changes
Oct 4, 2023
Wondertan
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the exchange will block peers for giving a bad header that does not pass the
Verifycheck (unless it is aSoftFailure). Unless we introduce another field inside ofVerifyErrorto indicate to the caller whether the error was severe enough to warrant blocking, we shouldn't blanket block for verify errors as a good peer that sends a slightly outdated header will get banned.(this is currently observable on
arabica- have not tested on mocha yet)Moral of the story: do not prematurely implement blocking behaviour.