refactor!: Merge GetVerifiedRange and GetRangeByHeight in Getter interface and remove redundant endpoint
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
tzdybal,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
renaynay
commented
Oct 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 69.57% 69.71% +0.14%
==========================================
Files 37 37
Lines 2938 2929 -9
==========================================
- Hits 2044 2042 -2
+ Misses 746 741 -5
+ Partials 148 146 -2
|
renaynay
commented
Oct 11, 2023
vgonkivs
approved these changes
Oct 11, 2023
distractedm1nd
approved these changes
Oct 11, 2023
Wondertan
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges
GetVerifiedRangefunctionality intoGetRangeByHeight(breaksGetRangeByHeightsignature and removesGetVerifiedRange)No need for two methods doing the same thing.
Also introduces
GetRangeonstore.Storeinterface to allow requesting local headers without passing in afromHeadfor verification - this prevents p2p server from needing to perform an additional read (to get thefromHead) from the store to perform theGetRangeByHeightrequest.