feat(p2p)!: parameters for Subscriber #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Wondertan
commented
Oct 11, 2023
•
Wondertan
commented
- Adds params and options for Subscriber
- NetworkID was optional in other places besides Subscriber.
- Fixes issue with optional network id where it results in '//'
- Unifies optionality for metrics
- Before we called InitMetrics on the component, while we could leverage existing options
- Thus it's breaking. We wanted to break Getter interface anyway.
- Fixed old breaking TODO
* Adds params and options for Subscriber * NetworkID was optional in other places besides Subscriber. * Fixes issue with optional network id where it results in '//' * Unifies optionality for metrics * Before we called InitMetrics on the component, while we could leverage existing options
Wondertan
requested review from
tzdybal,
renaynay,
vgonkivs and
gupadhyaya
as code owners
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 68.60% 69.02% +0.41%
==========================================
Files 37 37
Lines 2934 2967 +33
==========================================
+ Hits 2013 2048 +35
+ Misses 770 768 -2
Partials 151 151
|
distractedm1nd
previously approved these changes
Oct 11, 2023
renaynay
previously approved these changes
Oct 11, 2023
vgonkivs
requested changes
Oct 11, 2023
Co-authored-by: Viacheslav <[email protected]>
renaynay
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.