Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): metrics for Subscriber #119

Merged
merged 4 commits into from
Oct 19, 2023
Merged

feat(p2p): metrics for Subscriber #119

merged 4 commits into from
Oct 19, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Oct 11, 2023

Adds 4 metrics:

  • messageSize - Histogram
  • messageNum (Accepted/Ignored/Rejected) - Int64Counter
  • messageTime - Histogram
  • subscriptionNum - AsyncGauge

TODO - Graphana Dashboard

p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
p2p/subscriber.go Outdated Show resolved Hide resolved
p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
p2p/subscription.go Outdated Show resolved Hide resolved
p2p/subscription.go Outdated Show resolved Hide resolved
@Wondertan
Copy link
Member Author

Btw, @nashqueue, this PR reports sizes for Accepted headers.

p2p/subscriber.go Outdated Show resolved Hide resolved
p2p/subscriber.go Outdated Show resolved Hide resolved
p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
p2p/subscriber.go Outdated Show resolved Hide resolved
p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #119 (300cde6) into main (098c994) will decrease coverage by 1.30%.
Report is 2 commits behind head on main.
The diff coverage is 15.09%.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   69.20%   67.91%   -1.30%     
==========================================
  Files          37       38       +1     
  Lines        2981     3079      +98     
==========================================
+ Hits         2063     2091      +28     
- Misses        771      841      +70     
  Partials      147      147              
Files Coverage Δ
p2p/subscription.go 57.14% <75.00%> (+2.97%) ⬆️
sync/metrics.go 15.38% <0.00%> (ø)
p2p/subscriber.go 42.68% <33.33%> (-5.85%) ⬇️
p2p/subscriber_metrics.go 7.50% <7.50%> (ø)

... and 3 files with indirect coverage changes

@Wondertan Wondertan force-pushed the p2p/susbcriber/metrics branch from b028add to 296cf4e Compare October 18, 2023 13:44
@Wondertan Wondertan force-pushed the p2p/susbcriber/metrics branch 2 times, most recently from f865069 to 10a8563 Compare October 18, 2023 13:52
@Wondertan Wondertan force-pushed the p2p/susbcriber/metrics branch from 10a8563 to 71bea10 Compare October 18, 2023 13:53
renaynay
renaynay previously approved these changes Oct 18, 2023
p2p/subscriber_metrics.go Show resolved Hide resolved
p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
vgonkivs
vgonkivs previously approved these changes Oct 19, 2023
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some few small cosmetic remarks and optional suggestions.

p2p/subscriber.go Show resolved Hide resolved
p2p/subscriber_metrics.go Show resolved Hide resolved
p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
p2p/subscriber_metrics.go Outdated Show resolved Hide resolved
p2p/subscriber_metrics.go Show resolved Hide resolved
p2p/subscriber_metrics.go Show resolved Hide resolved
@Wondertan Wondertan dismissed stale reviews from vgonkivs and renaynay via 300cde6 October 19, 2023 10:51
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Wondertan Wondertan merged commit 09c272d into main Oct 19, 2023
2 checks passed
@Wondertan Wondertan deleted the p2p/susbcriber/metrics branch October 19, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants