-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(p2p): metrics for Subscriber #119
Conversation
Btw, @nashqueue, this PR reports sizes for Accepted headers. |
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
==========================================
- Coverage 69.20% 67.91% -1.30%
==========================================
Files 37 38 +1
Lines 2981 3079 +98
==========================================
+ Hits 2063 2091 +28
- Misses 771 841 +70
Partials 147 147
|
b028add
to
296cf4e
Compare
f865069
to
10a8563
Compare
10a8563
to
71bea10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some few small cosmetic remarks and optional suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Adds 4 metrics:
TODO - Graphana Dashboard