refactor(p2p): subscriber.Stop logs but ignores error from unregister topic validator #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
tzdybal,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 65.01% 64.97% -0.05%
==========================================
Files 39 39
Lines 3276 3275 -1
==========================================
- Hits 2130 2128 -2
- Misses 988 989 +1
Partials 158 158
|
Wondertan
reviewed
Oct 27, 2023
Wondertan
approved these changes
Mar 7, 2024
vgonkivs
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was caused by the fact that we now no longer ignore the error from unregister topic validator.
@Wondertan brought up a good point that the API of
Subscriberdoesn't enforceSetVerifierso it's possible to successfully Start the Subscriber without mounting a validator on it, but Stop would fail due to no validator being present.This PR reverts the change and logs/ignores the error from unregister topic validator.