Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional custom validation #128

Closed
wants to merge 1 commit into from
Closed

optional custom validation #128

wants to merge 1 commit into from

Conversation

S1nus
Copy link

@S1nus S1nus commented Oct 30, 2023

Overview

Sometimes, a rollup might want to customize the stateless validation behavior at runtime. For example, in a centralized sequencer scheme where the proposer pubkey is always known, this enables more efficient validation.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #128 (ae7cd19) into main (a8ce731) will decrease coverage by 0.68%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   65.01%   64.34%   -0.68%     
==========================================
  Files          39       39              
  Lines        3276     3290      +14     
==========================================
- Hits         2130     2117      -13     
- Misses        988     1011      +23     
- Partials      158      162       +4     
Files Coverage Δ
p2p/exchange.go 84.27% <100.00%> (ø)
p2p/session.go 87.56% <28.57%> (-2.24%) ⬇️
p2p/subscriber.go 38.46% <0.00%> (-4.23%) ⬇️

... and 2 files with indirect coverage changes

@S1nus
Copy link
Author

S1nus commented Nov 9, 2023

closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants