-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(p2p|sync): Only log head verification failure as error if it is not ErrKnownHeader #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making known headers a soft failure means we will use them as sync target which is wrong.
The issue here is not with the buggy logic but with the logging that confuses node operators, so the solution should be on the logging level, like demoting this error to WARN
Do you think we need this log as WARN or it should be DEBUG? Does this case need attention from node operator? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 63.77% 63.79% +0.01%
==========================================
Files 39 39
Lines 3382 3389 +7
==========================================
+ Hits 2157 2162 +5
- Misses 1059 1061 +2
Partials 166 166 ☔ View full report in Codecov by Sentry. |
Note that this PR suppresses a symptom of a problem (likely with |
Please make sure we have a descriptive issue for it and so we don't forget after vanishing it from logs. |
Known headers are not failing verification. They just ignored because we don't need them and thus can be reported as soft failure.