Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(p2p/peerTracker): fix bootstraping #169

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix(p2p/peerTracker): fix bootstraping #169

merged 1 commit into from
Apr 2, 2024

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Apr 2, 2024

Overview

The context was canceled before we performed any connection during bootstrap.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs self-assigned this Apr 2, 2024
ramin
ramin approved these changes Apr 2, 2024
View reviewed changes
Copy link

@ramin ramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

renaynay
renaynay approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to do the copying inside loops?

@vgonkivs
Copy link
Member Author

vgonkivs commented Apr 2, 2024

Yes, until we'll move to go1.22

@renaynay renaynay merged commit dbcee58 into celestiaorg:main Apr 2, 2024
2 checks passed
vgonkivs added a commit to vgonkivs/go-header that referenced this pull request Apr 2, 2024
@vgonkivs
Revert "fix(p2p/peerTracker): fix bootstraping (celestiaorg#169)"
ca440ae 
This reverts commit dbcee58.
vgonkivs added a commit that referenced this pull request Apr 2, 2024
@vgonkivs
fix(p2p/peerTracker): remove timeout during bootstrapping (#171)
6d0f9a4 
* Revert "fix(p2p/peerTracker): fix bootstraping (#169)"

This reverts commit dbcee58.

* fix(p2p/peerTracker): remove timeout during bootstrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@ramin ramin ramin approved these changes

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

Assignees

@vgonkivs vgonkivs

Labels
kind:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgonkivs @ramin @renaynay