Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): stop doing header verification in GetRangeByHeight #180

Merged
merged 2 commits into from
May 27, 2024

Conversation

cristaloleg
Copy link
Contributor

Overview

We don't need to verify headers on every GetRangeByHeight 'cause verification already happened in Append. No tests failed, added TestStore_Append_BadHeader to prevent bugs in the future.

Fixes #135

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vgonkivs vgonkivs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG 🚀

@cristaloleg
Copy link
Contributor Author

Thanks friends, waiting for Rene to take a look.

@cristaloleg
Copy link
Contributor Author

@renaynay kindly ping :)

store/store_test.go Show resolved Hide resolved
@renaynay renaynay enabled auto-merge (squash) May 27, 2024 12:59
@renaynay renaynay merged commit ea28e37 into main May 27, 2024
4 checks passed
@renaynay renaynay deleted the omit-verify-GetRangeByHeight branch May 27, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store: GetRangeByHeight should not Verify headers internally
4 participants