Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync, store)!: Remove adjacency requirement from Store.Append #186

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

cristaloleg
Copy link
Contributor

@cristaloleg cristaloleg commented May 27, 2024

Overview

Things that gonna change after we drop adjacency requirement from Store.Append:

  • Obviously dropping ErrNonAdjacent (breaking change).
  • Store.Append comment is already outdated (looks like there were 2 return params)
  • store.Store.Append will not verify for adjacency (obviously)
  • Syncer.setSubjectiveHead will not verify for ErrNonAdjacent
  • adjacency check is happening in sync instead of store.

Fixes #32

p2p/session.go Outdated Show resolved Hide resolved
p2p/session.go Outdated Show resolved Hide resolved
p2p/session.go Outdated Show resolved Hide resolved
store/batch.go Outdated Show resolved Hide resolved
store/batch.go Outdated Show resolved Hide resolved
store/store.go Outdated Show resolved Hide resolved
@cristaloleg cristaloleg force-pushed the store/drop-header-adj branch from 1260139 to 972c9b2 Compare June 3, 2024 14:47
@cristaloleg cristaloleg marked this pull request as ready for review June 3, 2024 15:11
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 62.75%. Comparing base (88c5b8c) to head (5a10a68).
Report is 11 commits behind head on main.

Current head 5a10a68 differs from pull request most recent head f10cce8

Please upload reports for the commit f10cce8 to get more accurate results.

Files Patch % Lines
sync/sync_store.go 56.25% 5 Missing and 2 partials ⚠️
store/heightsub.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   62.80%   62.75%   -0.05%     
==========================================
  Files          39       38       -1     
  Lines        3589     3587       -2     
==========================================
- Hits         2254     2251       -3     
- Misses       1160     1163       +3     
+ Partials      175      173       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cristaloleg cristaloleg changed the title feat: Remove adjacency requirement from Store.Append feat(sync, store)!: Remove adjacency requirement from Store.Append Jun 3, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so nothing really changes with this PR yet. We need to discuss what are there next changes in the Syncer

@cristaloleg cristaloleg merged commit 72d6506 into main Jun 10, 2024
4 checks passed
@cristaloleg cristaloleg deleted the store/drop-header-adj branch June 10, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store: Remove adjacency requirement from Store.Append
4 participants