-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sync, store)!: Remove adjacency requirement from Store.Append #186
Conversation
42d00c6
to
6ee77e4
Compare
1260139
to
972c9b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
- Coverage 62.80% 62.75% -0.05%
==========================================
Files 39 38 -1
Lines 3589 3587 -2
==========================================
- Hits 2254 2251 -3
- Misses 1160 1163 +3
+ Partials 175 173 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so nothing really changes with this PR yet. We need to discuss what are there next changes in the Syncer
Overview
Things that gonna change after we drop adjacency requirement from
Store.Append
:ErrNonAdjacent
(breaking change).Store.Append
comment is already outdated (looks like there were 2 return params)store.Store.Append
will not verify for adjacency (obviously)Syncer.setSubjectiveHead
will not verify forErrNonAdjacent
sync
instead ofstore
.Fixes #32