Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!feat(store): drop Init function #190

Closed
wants to merge 1 commit into from
Closed

!feat(store): drop Init function #190

wants to merge 1 commit into from

Conversation

cristaloleg
Copy link
Contributor

Overview

Literally what is mentioned in the issue: drop Init from exported space, keep it as an unexported function to keep a test.

Fixes #187

@cristaloleg
Copy link
Contributor Author

Closing as not that important now. See comment on #187

@cristaloleg cristaloleg deleted the store/drop-init-func branch May 29, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

store: drop Init function
1 participant
@cristaloleg