-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(store): properly update store head #207
Conversation
964e86f
to
a197550
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 62.80% 63.82% +1.01%
==========================================
Files 39 38 -1
Lines 3589 3621 +32
==========================================
+ Hits 2254 2311 +57
+ Misses 1160 1141 -19
+ Partials 175 169 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Overview
The main idea of this PR is to make
Store[H].Head
working properly, to be precise: returning head that was written to the disk (*). Along with thatheightSub.height
is increased monotonically to prevent bugs when we have store appends out of order.To test everything I'm adding 2 new tests: one that verifies out of order appends and another when which does this concurrently. Which helped to find 2 or even 3 edge cases during coding.
Fixes #201