Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming CompactShareReservedBytes to ShareReservedBytes #38

Closed
rootulp opened this issue Jun 15, 2023 · 1 comment · Fixed by #61
Closed

Consider renaming CompactShareReservedBytes to ShareReservedBytes #38

rootulp opened this issue Jun 15, 2023 · 1 comment · Fixed by #61
Assignees
@rootulp
Labels
good first issue Good for newcomers

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jun 15, 2023

https://github.com/celestiaorg/celestia-app/blob/e035e9637783a9481d7eab5307addb06b6049fa0/pkg/appconsts/global_consts.go#L47

to conform to the share specs and part of #30
@rootulp rootulp mentioned this issue Jun 15, 2023
Merged
@evan-forbes evan-forbes transferred this issue from celestiaorg/celestia-app Feb 27, 2024
@evan-forbes
Copy link
Member

evan-forbes commented May 27, 2024 •
edited by rootulp
Loading

note from @rootulp this doesn't have to be API breaking, as we can deprecate the old constant

@evan-forbes evan-forbes added the good first issue Good for newcomers label May 27, 2024
@rootulp rootulp self-assigned this May 27, 2024
@rootulp rootulp mentioned this issue May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename CompactShareReservedBytes to ShareReservedBytes rootulp/go-square
2 participants
@rootulp @evan-forbes