Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename CompactShareReservedBytes to ShareReservedBytes #61

Merged
merged 3 commits into from
May 28, 2024
Merged

refactor: rename CompactShareReservedBytes to ShareReservedBytes #61

merged 3 commits into from
May 28, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented May 27, 2024

Closes #38

@rootulp rootulp self-assigned this May 27, 2024
@rootulp rootulp requested review from a team as code owners May 27, 2024 18:16
@rootulp rootulp requested review from evan-forbes, ninabarbakadze, cristaloleg and Wondertan and removed request for a team May 27, 2024 18:16
@celestia-bot celestia-bot requested review from a team May 27, 2024 18:17
@rootulp rootulp enabled auto-merge (squash) May 27, 2024 18:18
@cristaloleg
Copy link
Contributor

cristaloleg commented May 27, 2024 •
edited
Loading

refactor: rename CompactShareReservedBytes to ShareReservedBytes ?

(note ! as the prefix). I see #38 (comment)

@rootulp rootulp changed the title refactor: rename to ShareReservedBytes refactor: rename CompactShareReservedBytes to ShareReservedBytes May 27, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented May 27, 2024

Included the longer PR title b/c that should be clearer

@rootulp rootulp merged commit 4063a54 into celestiaorg:main May 28, 2024
10 checks passed
@rootulp rootulp deleted the rp/ShareReservedBytes branch May 29, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@cristaloleg cristaloleg cristaloleg approved these changes

@ninabarbakadze ninabarbakadze Awaiting requested review from ninabarbakadze ninabarbakadze is a code owner automatically assigned from celestiaorg/celestia-core

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner automatically assigned from celestiaorg/celestia-node

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming CompactShareReservedBytes to ShareReservedBytes
3 participants
@rootulp @cristaloleg @evan-forbes