fix: add commands for generating go types #16
Conversation
cmwaters
requested review from
staheri14,
ninabarbakadze,
distractedm1nd and
Wondertan
and removed request for
a team
Makefile
Outdated
| ## proto-gen-docker: Generate protobuf files. Requires docker. | ||
| proto-gen-docker: | ||
| @echo "--> Generating Protobuf files" | ||
| $(DOCKER_BUF) generate | ||
| .PHONY: proto-gen-docker | ||
|
|
||
| ## proto-gen: Generate protobuf files. Requires buf. | ||
| proto-gen: | ||
| @echo "--> Generating Protobuf files" | ||
| @buf generate | ||
| .PHONY: proto-gen |
There was a problem hiding this comment.
[question] do we want to support two different ways to generate the Protobuf files? I think it may be easier to maintain just one option and if that option is used in CI as well as locally. Since the make proto-gen command depends on a locally installed Buf CLI, preference for the Docker approach.
Ideally the Docker approach uses the same version of Buf locally and in CI.
There was a problem hiding this comment.
We could probably look to enforce it somehow. The docker image also isn't versioned (I actually had a problem where it wasn't working because I had an old image.
I think some people don't like using docker, hence why I added the other option, but it's simple enough that it probably doesn't need a make command so I will remove it
There was a problem hiding this comment.
Yea I think the Docker approach should also be versioned but not blocking on it.
We might have different versions - let me dig into it |
Co-authored-by: Rootul P <[email protected]>
|
If it helps debug: |
It is the case for me too. |
|
Okay I had an older version of buf. I'm going to hardcode the version to 1.28.1 in the Makefile so hopefully that produces constant results |
|
Hmm we need to update settings on this repo so that new commits dismiss previous PR approvals. |
Done. I've also made it require two reviews like the other repos |
Closes: #13