Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary conversions #3

Merged
merged 3 commits into from
Jan 10, 2024
Merged

chore: remove unnecessary conversions #3

merged 3 commits into from
Jan 10, 2024

Conversation

estensen
Copy link
Contributor

No description provided.

rootulp
rootulp reviewed Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Before we merge this, I think we should merge a prerequisite PR that adds golangci-lint support.

Then this PR can add the unconvert linter to the golangci-lint config.

@estensen estensen requested review from a team as code owners January 6, 2024 05:41
@estensen estensen requested review from distractedm1nd and Wondertan and removed request for a team January 6, 2024 05:41
@celestia-bot celestia-bot requested a review from a team January 6, 2024 05:41
cmwaters
cmwaters approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@cmwaters cmwaters merged commit 2baf10f into celestiaorg:main Jan 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp left review comments

@cmwaters cmwaters cmwaters approved these changes

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner automatically assigned from celestiaorg/celestia-node

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner automatically assigned from celestiaorg/celestia-node

Assignees

@estensen estensen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estensen @rootulp @cmwaters